Skip to content

[fix] page.url.searchParams not set on first page land with static build #3650#3680

Closed
aolose wants to merge 2 commits intosveltejs:masterfrom
aolose:#3650
Closed

[fix] page.url.searchParams not set on first page land with static build #3650#3680
aolose wants to merge 2 commits intosveltejs:masterfrom
aolose:#3650

Conversation

@aolose
Copy link
Contributor

@aolose aolose commented Feb 2, 2022

fix #3650

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2b79dfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 2, 2022 •
edited
Loading

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 2b79dfd

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61faa46c8767720007818795

dreitzner
dreitzner suggested changes Feb 2, 2022
View reviewed changes
@Rich-Harris Rich-Harris mentioned this pull request Feb 15, 2022
Merged
5 tasks
@Rich-Harris
Copy link
Member

Rich-Harris commented Feb 15, 2022

Thank you — closing in favour of #3942, which has the same effect as far as search params go, but replaces the entire URL instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dreitzner dreitzner dreitzner requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

page.url.searchParams not set on first page land with static build

3 participants

@aolose @Rich-Harris @dreitzner